Skip to content

Commit 3b550ed

Browse files
committed
This fixes #76
1 parent 8097385 commit 3b550ed

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

rings/src/main/java/cc/redberry/rings/poly/multivar/MultivariateSquareFreeFactorization.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,8 @@ PolynomialFactorDecomposition<Poly> SquareFreeFactorizationYunZeroCharacteristic
117117
PolynomialFactorDecomposition<Poly> decomposition = PolynomialFactorDecomposition.unit(content[0]);
118118
addMonomial(decomposition, content[1]);
119119
SquareFreeFactorizationYun0(poly, decomposition);
120-
if (Util.isOverSimpleNumberField(poly)) {
121-
// lc correction (needed for number fields)
122-
decomposition.setLcFrom(original);
123-
}
120+
// lc correction
121+
decomposition.setLcFrom(original);
124122
return decomposition;
125123
}
126124

rings/src/test/java/cc/redberry/rings/poly/multivar/MultivariateSquareFreeFactorizationTest.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
import java.util.Arrays;
1919

2020
import static cc.redberry.rings.poly.multivar.MultivariateGCDTest.createMonomial;
21+
import static cc.redberry.rings.poly.multivar.MultivariateSquareFreeFactorization.SquareFreeFactorizationMusserZeroCharacteristics;
22+
import static cc.redberry.rings.poly.multivar.MultivariateSquareFreeFactorization.SquareFreeFactorizationYunZeroCharacteristics;
2123

2224
/**
2325
* @since 1.0
@@ -39,7 +41,7 @@ public void test1() throws Exception {
3941
FactorDecompositionTest.assertFactorization(poly, yun);
4042

4143
start = System.nanoTime();
42-
PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>> mus = MultivariateSquareFreeFactorization.SquareFreeFactorizationMusserZeroCharacteristics(poly);
44+
PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>> mus = SquareFreeFactorizationMusserZeroCharacteristics(poly);
4345
System.out.println("Musser: " + TimeUnits.nanosecondsToString(System.nanoTime() - start));
4446

4547
FactorDecompositionTest.assertFactorization(poly, mus);
@@ -155,4 +157,15 @@ public void test6() throws Exception {
155157
Assert.assertEquals(expected, MultivariateSquareFreeFactorization.SquareFreeFactorization(poly));
156158
}
157159
}
160+
161+
@Test
162+
public void test7() {
163+
MultivariatePolynomial<BigInteger>
164+
a = MultivariatePolynomial.parse("2*y^3-3*x*y^2+x^3");
165+
166+
PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>>
167+
r = SquareFreeFactorizationYunZeroCharacteristics(a);
168+
169+
FactorDecompositionTest.assertFactorization(a, r);
170+
}
158171
}

0 commit comments

Comments
 (0)