fix: spanId fixes (#15)

* some testing things

* get coverage data

* release: bump to 0.0.8

* Update lib/utils.js

Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

* Update lib/utils.js

Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

Author: thomasrockhu-codecov

lib/utils.js

@@ -58,7 +58,10 @@ class CoverageStorageManager {
     }
 
     getCoverageFromFile(filename) {
-        const rawdata = fs.readFileSync(path.join(covdir, filename));
+        if (typeof filename !== "string") {
+            return null
+        }
+        const rawdata = fs.readFileSync(path.join(covdir, filename), { encoding: "utf8" });
         const covdata = JSON.parse(rawdata);
         return parseCoverageObj(covdata);
     }
@@ -171,7 +174,7 @@ class CodecovExporter {
         for (const spanKey in spans) {
             const span = spans[spanKey];
             let coverageData = this.storageManager.popSpanCoverage(
-                span.spanContext.spanId
+                span.spanContext().spanId
             );
             if (coverageData) {
                 let processedCoverageData =
@@ -197,6 +200,7 @@ class CodecovExporter {
         if (trackedSpans) {
             this.submitCoverageData(
                 trackedSpans,
+                this.code,
                 (data) => {
                     // Done on purpose to check that we are calling
                     // this callback right
@@ -233,7 +237,7 @@ class CodecovExporter {
         req.end();
     }
 
-    submitCoverageData(trackedSpans, callback) {
+    submitCoverageData(trackedSpans, code, callback) {
         const data = JSON.stringify({
             profiling: code,
         });
@@ -285,13 +289,10 @@ class CodecovSpanProcessor {
     }
 
     _idFromSpan(span) {
-        return span.spanContext.spanId;
+        return span.spanContext().spanId;
     }
 
     _shouldSampleSpan(span) {
-        if (span.instrumentationLibrary.name !== "@opentelemetry/plugin-http") {
-            return false;
-        }
         if (this.filters) {
             if (
                 this.filters.allowedSpanKinds &&
@@ -322,10 +323,10 @@ class CodecovSpanProcessor {
     // up after that since we're going to clear it onStart. Also relinquish
     // the lock so we can capture another
     onEnd(span) {
-        if (span.spanContext.spanId == this.lock) {
+        if (span.spanContext().spanId == this.lock) {
             if (this.tracked) {
                 this.storageManager.stopCollectingAndSaveCoverage(
-                    span.spanContext.spanId
+                    span.spanContext().spanId
                 );
                 this.tracked = false;
             }
@@ -341,4 +342,4 @@ module.exports = {
     CoverageMappingManager,
     CodecovSpanProcessor,
     parseCoverageObj
-};
+};

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@codecov/node-codecov-opentelemetry",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "license": "MIT",
   "description": "",
   "main": "lib/runtime-insights.js",