Skip to content

Conversation

@calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Dec 8, 2025

Closes https://linear.app/getsentry/issue/CCMRG-1916/state-started-with-no-state-id-should-be-still-processing. Addresses a "manual trigger" problem where it is possibly prematurely sending the GH comment when not all of the uploads are processed yet. Two out of the ten uploads for commit becd4ee1962d197e8344e7582bdcebde7c0e7fa8 show as state "started" in the DB.


Note

Considers uploads with state "started" as still processing to prevent premature notifications.

  • Worker
    • Update apps/worker/tasks/manual_trigger.py to count uploads with state == "started" as still processing, alongside missing state or state_id == UploadState.UPLOADED.db_id, delaying notifications until all uploads complete.

Written by Cursor Bugbot for commit 13116c1. This will update automatically on new commits. Configure here.

@linear
Copy link

linear bot commented Dec 8, 2025

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-eu
Copy link

codecov-eu bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sentry
Copy link

sentry bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.86%. Comparing base (240de92) to head (13116c1).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   93.87%   93.86%   -0.01%     
==========================================
  Files        1284     1284              
  Lines       46528    46534       +6     
  Branches     1522     1522              
==========================================
+ Hits        43676    43677       +1     
- Misses       2542     2547       +5     
  Partials      310      310              
Flag Coverage Δ
workerintegration 58.60% <0.00%> (-0.01%) ⬇️
workerunit 91.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@calvin-codecov calvin-codecov added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 22359ca Dec 9, 2025
41 of 42 checks passed
@calvin-codecov calvin-codecov deleted the cy/manual_trigger_wait_for_started branch December 9, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants