fix: Also check if upload is in started state for manual trigger #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/CCMRG-1916/state-started-with-no-state-id-should-be-still-processing. Addresses a "manual trigger" problem where it is possibly prematurely sending the GH comment when not all of the uploads are processed yet. Two out of the ten uploads for commit becd4ee1962d197e8344e7582bdcebde7c0e7fa8 show as state "started" in the DB.
Note
Considers uploads with state "started" as still processing to prevent premature notifications.
apps/worker/tasks/manual_trigger.pyto count uploads withstate == "started"as still processing, alongside missingstateorstate_id == UploadState.UPLOADED.db_id, delaying notifications until all uploads complete.Written by Cursor Bugbot for commit 13116c1. This will update automatically on new commits. Configure here.