Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Dec 9, 2025

Fixes API-CPF. The issue was that: Duplicate Repository records exist due to an Owner created with a NULL username, violating implicit uniqueness.

  • Filter out GitLab groups with null or missing full_path during fetching to ensure valid group data.
  • Skip team synchronization if a team has a None username, preventing the creation of invalid Owner records.
  • Update GitLab webhook repository lookup to exclude repositories owned by accounts with None usernames, mitigating MultipleObjectsReturned errors.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 6288144

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/codecov-api/webhook_handlers/views/gitlab.py 71.42% 2 Missing ⚠️
apps/worker/tasks/sync_teams.py 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #606 will not alter performance

Comparing seer/fix/null-username-path-checks (e6e637a) with main (be995b4)1

Summary

✅ 9 untouched

Footnotes

  1. No successful run was found on main (22359ca) during the generation of this report, so be995b4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sentry
Copy link

sentry bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.86%. Comparing base (be548da) to head (e6e637a).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/codecov-api/webhook_handlers/views/gitlab.py 71.42% 2 Missing ⚠️
apps/worker/tasks/sync_teams.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   93.87%   93.86%   -0.01%     
==========================================
  Files        1284     1284              
  Lines       46667    46679      +12     
  Branches     1522     1522              
==========================================
+ Hits        43809    43817       +8     
- Misses       2548     2552       +4     
  Partials      310      310              
Flag Coverage Δ
apiunit 96.56% <71.42%> (-0.02%) ⬇️
sharedintegration 38.80% <ø> (+<0.01%) ⬆️
sharedunit 88.77% <ø> (+<0.01%) ⬆️
workerintegration 58.59% <33.33%> (-0.01%) ⬇️
workerunit 91.19% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant