Remove retrials of fixed tests #64740
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated according to dotnet/aspnetcore-internal#4769 (comment). For these 2 removals we know what fixed it. `CertificateChangedOnDisk` might be lucky to not pass for the last 90 days. Leaving on the list. `CheckInvalidHostingModelParameter` - due to its dependence on deployment, HTTP, event logging I am not 100% sure if we should remove it. It's up to discussion or can be done later when another 90 days of all-green period will be confirmed.
github-actions
bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two flaky test entries from the test retry configuration that have been stabilized. The tests ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit and ComponentDisposeMethodThrowsExceptionTerminatesTheCircuit from the Components E2E test suite are no longer considered flaky and don't require automatic retries.
Key Changes
wtgodbe
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated according to https://github.com/dotnet/aspnetcore-internal/issues/4769#issuecomment-3642606696.
For these 2 removals we know what fixed it.
CertificateChangedOnDiskmight be lucky to pass for the last 90 days. Leaving on the list.CheckInvalidHostingModelParameter- due to its dependence on deployment, HTTP, event logging I am not 100% sure if we should remove it. It's up to discussion or can be done later when another 90 days of all-green period will be confirmed.Fixed by #63143.