Skip to content

Conversation

@depial
Copy link
Contributor

@depial depial commented Dec 11, 2025

I've tried to improve the readability of permutations.jl while bringing the implementation more in line with what is currently in Combinatorics.jl/main mostly by renaming variables, but also some other minor style changes.

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@depial
Copy link
Contributor Author

depial commented Dec 11, 2025

We should put [no important files changed] in the merge-commit message.

@depial depial requested a review from colinleach December 11, 2025 19:04
@colinleach colinleach merged commit f2bce00 into exercism:main Dec 11, 2025
7 checks passed
@depial depial deleted the permutations-update branch December 11, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants