-
Notifications
You must be signed in to change notification settings - Fork 160
fix(video): add missing tooltip to stages create button #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
fix(video): add missing tooltip to stages create button #1465
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a missing tooltip to the Stages creation button in the video sidebar to align its behavior with the Channels and Direct Messages creation buttons. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The tooltip label is hardcoded as "Create Stage" while surrounding labels use
$t(...); consider introducing a translation key for this tooltip to keep localization consistent. - If other sidebar creation buttons (e.g., Channels, Direct Messages) use specific tooltip props (like different
tooltip-fixedsettings or delay), aligning this button’s configuration with them would help maintain consistent behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tooltip label is hardcoded as "Create Stage" while surrounding labels use `$t(...)`; consider introducing a translation key for this tooltip to keep localization consistent.
- If other sidebar creation buttons (e.g., Channels, Direct Messages) use specific tooltip props (like different `tooltip-fixed` settings or delay), aligning this button’s configuration with them would help maintain consistent behavior.
## Individual Comments
### Comment 1
<location> `app/eventyay/webapp/src/components/RoomsSidebar.vue:14` </location>
<code_context>
.group-title#stages-title(v-if="roomsByType.stage.length || hasPermission('world:rooms.create.stage')")
span {{ $t('RoomsSidebar:stages-headline:text') }}
- bunt-icon-button(v-if="hasPermission('world:rooms.create.stage')", @click="showStageCreationPrompt = true") plus
+ bunt-icon-button(v-if="hasPermission('world:rooms.create.stage')", tooltip="Create Stage", :tooltip-fixed="true", @click="showStageCreationPrompt = true") plus
.stages(role="group", aria-describedby="stages-title")
router-link.stage(v-for="stage of roomsByType.stage", :to="stage.room === rooms[0] ? {name: 'home'} : {name: 'room', params: {roomId: stage.room.id}}", :class="{active: stage.room.id === $route.params.roomId, session: stage.session, live: stage.session && stage.room.schedule_data, 'has-image': stage.image, 'starts-with-emoji': startsWithEmoji(stage.room.name)}")
</code_context>
<issue_to_address>
**suggestion:** Localize the tooltip string instead of hardcoding English text.
This component already uses `$t(...)` for other labels, but the new tooltip is a hardcoded English string. Please localize it, e.g. `:tooltip="$t('RoomsSidebar:create-stage:tooltip')"` (or a key consistent with your i18n scheme), to avoid introducing an untranslated UI string.
Suggested implementation:
```
bunt-icon-button(v-if="hasPermission('world:rooms.create.stage')", :tooltip="$t('RoomsSidebar:create-stage:tooltip')", :tooltip-fixed="true", @click="showStageCreationPrompt = true") plus
```
You will also need to add the `RoomsSidebar:create-stage:tooltip` key (and translations) to your i18n resource files (e.g. en.json and other locales), with an appropriate localized string such as `"RoomsSidebar:create-stage:tooltip": "Create Stage"`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The '+' button for Stages was missing a tooltip. Added 'Create Stage' tooltip to maintain consistency with Channels and Direct Messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a UI inconsistency by adding a missing tooltip to the Stages creation button in the Video Sidebar. The change ensures consistent user experience across all sidebar creation buttons (Channels, Direct Messages, and Stages).
Key Changes:
- Added "Create Stage" tooltip to the stages creation button using proper i18n translation
- Cleaned up duplicate translation key entries in the locale file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/eventyay/webapp/src/locales/en.json |
Added new translation key RoomsSidebar:create-stage:tooltip for the stages button tooltip and removed duplicate PosterHall:filter:field-tag entries |
app/eventyay/webapp/src/components/RoomsSidebar.vue |
Added tooltip attributes (:tooltip and :tooltip-fixed) to the stages creation button to display "Create Stage" on hover |
The implementation correctly follows Vue's internationalization patterns and maintains consistency with the existing tooltip implementation style. The bonus cleanup of duplicate translation keys in the locale file improves code quality.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR fixes a UI inconsistency in the Video Sidebar where the "Stages" creation button (
+) was missing a tooltip.The "Channels" and "Direct Messages" buttons already display tooltips when hovered. This change adds the missing tooltip "Create Stage" to the Stages button to ensure a consistent user experience.
Fixes:#1457
Before


After
Summary by Sourcery
Bug Fixes: