Skip to content

Refactor compare router param parse and fix bugs #36105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lunny wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Refactor compare router param parse and fix bugs #36105

lunny wants to merge 15 commits into from
+558 −155

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 8, 2025 •
edited
Loading

Fix #36116
Fix #35912
Fix #20906

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 8, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 8, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 8, 2025
techknowlogick
techknowlogick reviewed Dec 8, 2025
View reviewed changes
@lunny @techknowlogick
Update routers/common/compare_test.go
44925e3 
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>
@a1012112796
Copy link
Member

a1012112796 commented Dec 10, 2025

please have a look at #36116

@lunny lunny marked this pull request as ready for review December 10, 2025 23:25
@lunny lunny changed the title Refactor compare router param parse Refactor compare router param parse and fix bugs Dec 11, 2025
@lunny
Copy link
Member Author

lunny commented Dec 11, 2025

please have a look at #36116

This has been included and it's ready to review now.

@lunny lunny added the type/bug label Dec 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@a1012112796 a1012112796 Awaiting requested review from a1012112796

1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/v1.25 lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/translation type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

No milestone

5 participants

@lunny @a1012112796 @techknowlogick @Zettat123 @GiteaBot