tests: improve various CLI test coverage #8262
Open
+143
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higgsd
force-pushed
the
higgsd/more-cli-coverage
branch
4 times, most recently
from
65c9fca to
fa148cc
Compare
rayaq-siddiqui
left a comment
rayaq-siddiqui
left a comment
There was a problem hiding this comment.
Looks great to me! I tested the sign/sparse/util tests and test_install_man_pages test locally in the jj cli and the output matches the test. Just have a question about the --abort flag below.
yuja
approved these changes
Dec 11, 2025
Comment on lines
377
to
378
| // Unsign multiple commits, including a previously-unsigned revision | ||
| let output = work_dir.run_jj(["unsign", "-r", "..@"]); |
Contributor
There was a problem hiding this comment.
nit: It's more interesting to see rebased descendants "keep"s signed state. For example, if the @ revision was signed, unsign -r ..@- will rewrite the @ revision, which will have to be re-signed.
Contributor
Author
There was a problem hiding this comment.
Done, what do you think?
martinvonz
reviewed
Dec 11, 2025
higgsd
force-pushed
the
higgsd/more-cli-coverage
branch
from
fa148cc to
e46f915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of the same, like #8165. Feedback welcome.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)