diff: reduce intensity of context line numbers in color-words diffs #8294
+191
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling of dim and bold is a bit complicated because these two attributes cannot be unset individually. I think NormalIntensity will work for resetting both bold and dim, but I don't have expertise on terminal implementations. So this patch applies the same workaround as bold to dim.
This will help notice small hunks in inlined diff lines. Not all terminals would support "dim" attribute, but I think that's okay since the diff output should be readable with/without this change. Closes #5140
Contributor
|
@yuja What's the config you're using for your second screenshot? |
Contributor
Author
[colors]
"diff context" = { dim = true }
"diff token" = { underline = false }
"diff added token" = { fg = "bright green", bg = "#002200" }
"diff removed token" = { fg = "bright red", bg = "#330000" }It's basically the same as the doc example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5140
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)default:
dim context line number + text, highlight with fg/bg:
