Use LLVM_ENABLE_RUNTIMES for building compiler-rt in Green Dragon #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azharudd
reviewed
Dec 10, 2025
Contributor
azharudd
left a comment
azharudd
left a comment
There was a problem hiding this comment.
One comment. LGTM otherwise.
Contributor
There was a problem hiding this comment.
Please skip the changes to this file from this PR. Only the files in jenkins directories are applicable to Green Dragon.
Contributor
There was a problem hiding this comment.
Also add to the title "in Green Dragon". (as there are some Buildbot bots that are not using runtimes yet)
Contributor
There was a problem hiding this comment.
I think this script was added by @asb so I assume they will change it when they're ready.
Actually I'm thinking of the other qemu script, sorry for the unnecessary ping.
ndrewh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building compiler-rt with LLVM_ENABLE_PROJECTS is deprecated and will be removed in a future release. This builds compiler-rt with LLVM_ENABLE_RUNTIMES.
Note that if any of these builds are used for release branches that do not yet have llvm/llvm-project#166837, we may want to either cherry-pick that to the release branches or hold off on this PR.