Add DynamicToolset support in Temporal
#3682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
requested changes
Dec 9, 2025
pydantic_ai_slim/pydantic_ai/durable_exec/temporal/_dynamic_toolset.py
Outdated
Show resolved
Hide resolved
tests/test_temporal.py
Outdated
| assert output == 'Dynamic result received' | ||
|
|
||
|
|
||
| # Test with explicit id parameter |
Collaborator
There was a problem hiding this comment.
I'd rather test the new id arg where we test the @agent.toolset decorator, since this part is not Temporal-specific
tests/test_temporal.py
Outdated
| pytest.fail('TemporalDynamicToolset not found in toolsets') | ||
|
|
||
|
|
||
| async def test_dynamic_toolset_get_tools_outside_workflow(): |
Collaborator
There was a problem hiding this comment.
We should test this by running the same agent we created earlier outside of a workflow, and checking that we still get the correct result
tests/test_temporal.py
Outdated
| pytest.fail('TemporalDynamicToolset not found') | ||
|
|
||
|
|
||
| async def test_dynamic_toolset_call_tool_outside_workflow(): |
tests/test_temporal.py
Outdated
| pytest.fail('TemporalDynamicToolset not found') | ||
|
|
||
|
|
||
| async def test_dynamic_toolset_tool_not_found_in_activity(): |
Collaborator
There was a problem hiding this comment.
I'm fine with pragma: no cover for this UserError like we have here:
2 tasks
Core changes: - DynamicToolset: convert to plain class with custom __init__, add copy() - TemporalDynamicToolset: use _call_tool_in_activity shared method - TemporalFunctionToolset: use _call_tool_in_activity shared method - temporalize_toolset: move DynamicToolset import to top Test changes: - Add test_fastmcp_dynamic_toolset_in_workflow for MCP lifecycle in DynamicToolset - Add test_dynamic_toolset_id and test_agent_toolset_decorator_id - Update test_visit_and_replace for DynamicToolset plain class 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3390
@agent.toolsetdecorator