fix: correctly pass options to toOpenAPISchema in resolver
#181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resolverfunction takes in aoptionsparameter, and passed it to bothtoJsonSchemaandtoOpenAPISchema. However these two functions actually expects two different shapes of theoptions. FortoJsonSchema, the options is directly passed to the underlaying schema lib. But fortoOpenAPISchema, it takes in { component, options }, and the latter sub-optionsis passed to the actual schema libs.The test i added is a good example of the use case that requires user to pass options to underlaying lib (in this example, zod), and shows how the new interface should be used.
The current API design is far from perfect, but this is the best solution I can think of to avoid breaking changes.