Refactor base64 handling in DocRecord and related structs

[ezeslucky]

Summary by CodeRabbit

• Bug Fixes

  • Improved base64 decoding error handling with clearer error messages.

• Documentation

  • Updated inline comments for data fields to clarify base64 encoding format.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

Refactored base64 handling in TryFrom implementations to use standardized decoding with proper error mapping. Simplified multi-line Ok() wrappers to single-line expressions in DocStoragePool methods. Updated inline comments on bin/data fields to document base64 encoding. No changes to public APIs or functional behavior.

Changes

Cohort / File(s)

Summary

Base64 Decoding & DocStoragePool Refactoring packages/frontend/mobile-native/src/lib.rs

Reworked base64 handling in multiple TryFrom implementations to decode via base64_simd::STANDARD.decode_to_vec() with error mapping to UniffiError::Base64DecodingError. Simplified multi-line Ok() wrappers to single-line expressions in DocStoragePool methods (set_space_id, push_update, set_doc_snapshot, delete_doc, set_blob, delete_blob, crawl_doc_data). Updated inline comments for bin/data fields to indicate base64 encoding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Base64 error handling: Verify the decode-to-vec pattern and error mapping is consistent across all TryFrom implementations
• DocStoragePool expression simplification: Confirm single-line refactoring preserves original control flow and return values

Poem

🐰 Base64 bytes hop and decode,
With SIMD's speedy stroke,
Comments bloom like carrots true,
Ok() lines are slimmer too!
Refactored burrows, clean and neat! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: refactoring base64 handling in DocRecord and related structs, which is confirmed by the detailed summary.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/frontend/mobile-native/src/lib.rs (2)

269-275: Consider improving indentation consistency.

The indentation in the push_update call appears inconsistent. Line 270 (doc_id,) has less indentation than expected for method arguments.

Apply this diff to improve alignment:

-         .push_update(
-    doc_id,
-    base64_simd::STANDARD
-      .decode_to_vec(update)
-      .map_err(|e| UniffiError::Base64DecodingError(e.to_string()))?,
-)
-
+        .push_update(
+          doc_id,
+          base64_simd::STANDARD
+            .decode_to_vec(update)
+            .map_err(|e| UniffiError::Base64DecodingError(e.to_string()))?,
+        )

---

658-658: Remove unnecessary clone.

universal_id.clone() is unnecessary here since universal_id is not used elsewhere in this method. Pass universal_id directly to avoid the allocation.

Apply this diff:

-    let result = self.inner.get(universal_id.clone()).await?.crawl_doc_data(&doc_id).await?;
+    let result = self.inner.get(universal_id).await?.crawl_doc_data(&doc_id).await?;

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 396cda2 and 34b9acd.

📒 Files selected for processing (1)

• packages/frontend/mobile-native/src/lib.rs (15 hunks)

🔇 Additional comments (4)

packages/frontend/mobile-native/src/lib.rs (4)

32-32: LGTM! Helpful documentation.

The inline comments clearly document that these fields contain base64-encoded data, improving code clarity for maintainers and API consumers.

Also applies to: 67-67, 128-128, 149-149

---

240-240: LGTM! Concise constructor.

The single-line constructor using Default::default() is idiomatic Rust and improves readability.

---

255-255: LGTM! Cleaner error propagation.

The single-line Ok(...) expressions reduce boilerplate and improve readability while maintaining the same error propagation behavior.

Also applies to: 299-299, 347-347, 405-405, 414-414

---

52-55: Verify that affine_nbstore::DocRecord::bin field type implements From<Vec<u8>> or is of type Vec<u8>.

The refactored code at lines 52-55 uses .into() to convert the decoded Vec<u8> to the target field type. This conversion requires the target type to implement From<Vec<u8>>. Confirm the actual type of the bin field in affine_nbstore::DocRecord supports this conversion.