-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: roll back electron version to v35 #14089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: roll back electron version to v35 #14089
Conversation
WalkthroughElectron devDependency in the frontend Electron app was downgraded from ^36.0.0 to ^35.0.0 in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
71-71: Consider adding a comment documenting the known Electron v36 worker issue.The downgrade itself is straightforward and consistent with the parallel change in the electron app's package.json. However, since this is a temporary rollback due to a known issue ("all workers do not work" in v36), adding an inline comment referencing the issue would help future maintainers understand the constraint and know when it's safe to upgrade.
"cross-env": "^7.0.3", - "electron": "^35.0.0", + "electron": "^35.0.0", // TODO: upgrade to v36+ once worker issues are resolved (see #XXXXX) "eslint": "^9.16.0",Replace
#XXXXXwith the actual GitHub issue number tracking the Electron v36 worker problem.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
package.json(1 hunks)packages/frontend/apps/electron/package.json(1 hunks)
🔇 Additional comments (2)
packages/frontend/apps/electron/package.json (2)
62-62: Approve the consistent downgrade; suggest adding a comment for clarity.This change is consistent with the root package.json update. Similarly, consider adding a comment here to document the known issue and link to any tracking issue, so both locations have the rationale documented.
"debug": "^4.4.0", - "electron": "^35.0.0", + "electron": "^35.0.0", // TODO: upgrade to v36+ once worker issues are resolved (see #XXXXX) "electron-log": "^5.4.3",
62-62: No issues found. The Electron version update to ^35.0.0 is complete across the codebase with no remaining v36 references in package files or lock files.
703e578 to
6435028
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14089 +/- ##
==========================================
- Coverage 56.41% 56.41% -0.01%
==========================================
Files 2759 2759
Lines 138567 138567
Branches 21174 21170 -4
==========================================
- Hits 78172 78166 -6
+ Misses 58230 58123 -107
- Partials 2165 2278 +113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|


In electron v36, all workers do not work.
The webpack configuration is too complicated, so go back first.
If start a new project with forge and latest electron, the worker works well.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.