Skip to content

Conversation

@fundon
Copy link
Collaborator

@fundon fundon commented Dec 11, 2025

In electron v36, all workers do not work.
The webpack configuration is too complicated, so go back first.

If start a new project with forge and latest electron, the worker works well.

Summary by CodeRabbit

  • Chores
    • Downgraded the Electron development/runtime used for building and testing the desktop app from v36 to v35; this is a development-environment change with no functional or API changes affecting end users.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Walkthrough

Electron devDependency in the frontend Electron app was downgraded from ^36.0.0 to ^35.0.0 in packages/frontend/apps/electron/package.json.

Changes

Cohort / File(s) Change Summary
Electron devDependency downgrade
packages/frontend/apps/electron/package.json
DevDependency electron changed from ^36.0.0^35.0.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change: version string in a devDependency.
  • Quick checks:
    • Confirm lockfile (yarn.lock / package-lock.json) updated accordingly.
    • Run CI/build to ensure no Electron-related regressions.

Poem

🐰 I hopped the version line today,
Thirty-six to thirty-five, I play —
A tiny step, a careful nibble,
Build hums on, my whiskers wiggle. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: roll back electron version to v35' directly matches the main change: reverting the electron dependency from v36 to v35.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the app:electron Related to electron app label Dec 11, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

71-71: Consider adding a comment documenting the known Electron v36 worker issue.

The downgrade itself is straightforward and consistent with the parallel change in the electron app's package.json. However, since this is a temporary rollback due to a known issue ("all workers do not work" in v36), adding an inline comment referencing the issue would help future maintainers understand the constraint and know when it's safe to upgrade.

     "cross-env": "^7.0.3",
-    "electron": "^35.0.0",
+    "electron": "^35.0.0", // TODO: upgrade to v36+ once worker issues are resolved (see #XXXXX)
     "eslint": "^9.16.0",

Replace #XXXXX with the actual GitHub issue number tracking the Electron v36 worker problem.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f832b28 and 88170d3.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • packages/frontend/apps/electron/package.json (1 hunks)
🔇 Additional comments (2)
packages/frontend/apps/electron/package.json (2)

62-62: Approve the consistent downgrade; suggest adding a comment for clarity.

This change is consistent with the root package.json update. Similarly, consider adding a comment here to document the known issue and link to any tracking issue, so both locations have the rationale documented.

     "debug": "^4.4.0",
-    "electron": "^35.0.0",
+    "electron": "^35.0.0", // TODO: upgrade to v36+ once worker issues are resolved (see #XXXXX)
     "electron-log": "^5.4.3",

62-62: No issues found. The Electron version update to ^35.0.0 is complete across the codebase with no remaining v36 references in package files or lock files.

@fundon fundon force-pushed the fix-workers-in-electron branch from 703e578 to 6435028 Compare December 11, 2025 23:12
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.41%. Comparing base (f832b28) to head (6435028).
⚠️ Report is 2 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #14089      +/-   ##
==========================================
- Coverage   56.41%   56.41%   -0.01%     
==========================================
  Files        2759     2759              
  Lines      138567   138567              
  Branches    21174    21170       -4     
==========================================
- Hits        78172    78166       -6     
+ Misses      58230    58123     -107     
- Partials     2165     2278     +113     
Flag Coverage Δ
server-test 77.04% <ø> (ø)
unittest 31.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darkskygit
Copy link
Member

which worker not work? shared worker seems work fine

image

@fundon
Copy link
Collaborator Author

fundon commented Dec 12, 2025

v0.25.5 stable
Screenshot 2025-12-12 at 10 43 19 AM

@darkskygit darkskygit added this pull request to the merge queue Dec 12, 2025
Merged via the queue into toeverything:canary with commit 246e09e Dec 12, 2025
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:electron Related to electron app

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants