Replace Modal with new Dialog component #41917
Open
+2,232
−3,726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New component that leverages the native HTML <dialog> element for modals and non-modal dialogs with built-in backdrop and accessibility support. Features: - Modal dialogs using showModal() with automatic backdrop - Non-modal dialogs using show() for persistent UI elements - Static backdrop option (prevents close on outside click) - Keyboard support (Escape to close, focus trapping for modals) - Smooth open/close animations via CSS - Events: show, shown, hide, hidden, hidePrevented - Data API for toggling with data-bs-toggle="dialog" JavaScript: - js/src/dialog.js - Main component class - js/tests/unit/dialog.spec.js - Unit tests - js/tests/visual/dialog.html - Visual test page SCSS: - scss/_dialog.scss - Component styles Docs: - Add dialog component documentation - Update modal docs with dialog references
mdo
force-pushed
the
feature/dialog-component
branch
from
89df9d6 to
8874a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to replace Modal in v6, built on
<dialog>with reduced JS thanks to browsers. Same functionality, but with new<dialog>element, and thus, a simplified JS plugin.